fix(community/milvus): Milvus vector store client: ignore auto-calculated fields in collection schema during upsert payload validation #9326
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ayanyev
changed the title
ayanyev
changed the title
ayanyev
changed the title
ayanyev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 9305
Current state:
Milvus vector store client expects server-side auto-calculated field value to be explicitly provided in Document's metadata. If field is not present in metadata, error is thrown by the client. If dummy data is provided through metadata to satisfy client, error is thrown by server, which does not expect such field in payload.
Target state:
Milvus vector store client does not expect that such field will be sent to server as part of Document's metadata on any insert or update request.
PR removes such fields from the list of Milvus collection schema fields.